Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
** DO NOT MERGE: Early pull request for the purposes of discussion. **
Index seeking provides the ability for an adapter to return records from relations based on attribute look up rather than all the records at once (aka full table scan). To name a few uses of this:
SelectionOp(LoadOp('blah'), Eq(Var('pk'), Const(1)) -> IndexSeek('blah', pk=1)
At evaluation time the dataset will then retrieve the need records by calling adapter.index_seek('blah', pk=1), which presumably will retrieve the matching record without performing a full table scan.
My current thought is that LoadOp during evaluation will be replaced withe either TableScan or IndexSeek operations as determined by the Adapter. TableScan operation will be the equivalent of todays LoadOps, i.e. the adapter returns all records and lets the rest of the splicer machinery handle the relational operations. IndexSeek will return a limited set of records. They'll have the ability to express which attributes must be bound in order to preform the IndexSeek.