fix: Set correct log output stream #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
yinggeh
changed the title
rmccorm4
reviewed
Jun 5, 2025
| file_stream_ << msg << std::endl; | ||
| } else { | ||
| } else if (level == Level::kINFO) { | ||
| std::cout << msg << std::endl; |
Contributor
There was a problem hiding this comment.
Tried doing some brief research on this topic from perf perspective, main difference between stdout/stderr is whether they're buffered or not. From some brief searching, it seems relatively standard practice to log info stdout and warn/error+ to stderr for enterprise applications.
Any original context or importance of using stderr for everything you're aware of @GuanLuo?
GuanLuo
approved these changes
Jun 6, 2025
rmccorm4
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all triton logs (INFO, WARNING, ERROR) are written into
stderr. Changing the output stream of INFO log tostdout.Some common practive I found
stdoutvsstderr. As @rmccorm4 mentioned, it seems relatively standard practice to log info stdout and warn/error+ to stderr for enterprise applications.Test PR: triton-inference-server/server#8236