project-9 #1
Open
project-9 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finished the html and css for the desktop view of the website
added code for different resolutions for a responsive design.
added adjustments to the code for better responsive designs
optimized images and added hover effects to buttons.
added more settings for a responsive design.
changed semantic tags, better structure with header and main class now in appropriate order.
removed extra viewport meta
made sure backgrounds extend to the edge of the viewport as well as changing some names of the classes.
renamed the image files and the source link to not contain white spaces.
removed redundant lines and added code for overflowing text on profile box
changed classes and blocks, adjusted dimensions on smaller resolutions
added video and adjusted font size on tablet
added different font sizes for header and desc on tablet
removed duplicated styles on media queries. moved major styles to its own block.
added javascript to the project.
added modal code for view on edit profile
added interactions to edit profile
added id to modal and used the id for the queries on js.
removed keyframes
Feature/edit profile function
added id on form as well as an appropriate form accessor in javascript for better performance
slight fix in position of function call.
changed variable declarator
refactor: changed for loop to forEach for a more concise code.
adjusted display to accomodate safari
added primairy codes for validation
added functionality on closing modals with overlay clicks + escape button; validation now works as intended
UX improvements and functioning validations
moved most code to their respective files, and declared an object for better accessibility
fixed error message not disappearing on profile modal everytime the modal is opened and the profile text contents gets refreshed
removed redundant code, fix button stuck on enabled after submitting a card form
refactored code to be modula; uses a FormValidator class, hotfixes on descriptions, separate files for constants, etc.
installed necessary libraries for webpack
fixed links to images
added new pop ups for delete, an option to change the avatar, etc.
added avatar modal to change avatar profile picture
added new event listeners for the modal
all the new pop ups, as well as the APIs and functions of all the elements have been successfully implemented.
Uploads now show loading text before successful attempts. Added max width to avaatars.
fixed duplicate codes, repeated DOM searches, fixed validation resets, refactored API codes, etc.
Revert "Webpack"
Update index.js
Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.