Respect authentication type on Android #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@tripflex |
arsenal942
requested changes
Nov 26, 2019
| for (WifiConfiguration test : currentNetworks) { | ||
| if (test.SSID != null && test.SSID.equals(ssid)) { | ||
| networkId = test.networkId; | ||
| if (test.SSID != null) { |
Collaborator
There was a problem hiding this comment.
Suggest changing test to something more appropriate.
Collaborator
There was a problem hiding this comment.
Pretty trivial change but I don't like variables test in production code.
Author
There was a problem hiding this comment.
Wow forgot this PR was open ^^currently messing with master to get IP on iOS. will refactor for better PR later
Collaborator
There was a problem hiding this comment.
All good - Did you ever get around to fixing it up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Differentiate between different network authentication types when retrieving networks by SSID. This is necessary because android stores multiple networks with same SSID but different types.
Benefits
Fixes a problem where one cannot connect to an unsecured network when there is a configuartion with WPA/WPA2 already configured.