ruby: Prevent concurrent usage of Trilogy connections #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a trology connection in a concurrent way will likely lead to various protocol errors, but can also lead to various crashes. As such it is preferable if Trilogy raises a clear to understand and deterministic error. I chose to implement this on the Ruby side, because it's simpler and more straightforward. I initially tried to do it in C, but the `_cb_wait` callback may raise or throw, so we'd need to use `rb_protect`, and release the lock there. The problem is the callback doesn't have access to the `trilogy_context` struct, so can't release the lock. If we're adament this should be done in C, we'll need a much larger refactor.
|
This makes sense to me! Nice work. I don't have a strong opinion about the implementation, but this is better than crashing for sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a trology connection in a concurrent way will likely lead to various protocol errors, but can also lead to various crashes.
As such it is preferable if Trilogy raises a clear to understand and deterministic error.
I chose to implement this on the Ruby side, because it's simpler and more straightforward.
I initially tried to do it in C, but the
_cb_waitcallback may raise or throw, so we'd need to userb_protect, and release the lock there. The problem is the callback doesn't have access to thetrilogy_contextstruct, so can't release the lock.If we're adament this should be done in C, we'll need a much larger refactor.
cc @tenderlove @jhawthorn