-
Notifications
You must be signed in to change notification settings - Fork 12
Cleanup of simulation code #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…tion. Clean up firmware code.
|
I'm fairly new to git too.. all those extra commits are from merging into upstream. I've learned from traumflug that it's much cleaner to keep a branch in sync with upstream as fast-forward updates don't show up as commits, and keep local changes in a separate branch which you then cherry-pick across to the sync branch in between git pull and git push, then rebase your local against the sync to complete moving the commits from one to the other. |
|
~/FiveD_on_Arduino/simulation $ make need to override dda.c too I think, or at least override a ton of macros. those errors will be coming from stuff like power_on() and x_direction() and x_step() and similar- things from arduino.h.. maybe overriding arduino.h would work better? |
|
Triffid, you need to run "make sim". I included the original Makefile and if you just run "make", it will try to build a hex file from the x86 code... |
Hi,
since Traumflug said that keeping the simulation code in the same directory causes trouble with the Arduino IDE, I moved all simulation code into a sub-directory. I also cleaned up the firmware code to use less #ifdefs. Also I fixed a timer bug in the simulation code.
I'm new to Git and I can't figure out why there are now six commits instead of a single one. It should be the one labelled 009faa2.
I am currently playing around with plotting data from the simulation so that we can see speed and acceleration curves but that code is not ready yet.
Regards,
Stephan