-
Notifications
You must be signed in to change notification settings - Fork 1
TypeDAL 4.0 | Python 3.14 support #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(forward reference) annotations
…ion to prevent breaking changes (clirunner in test)
…n 3.14
```python
bobby_tables = "Robert'); DROP TABLE Students;--"
rows = db.executesql(t"SELECT * FROM unhackable where name = {bobby_tables}")
name = "Robert'); DROP TABLE Students;--"
rows = database.executesql(t"SELECT * FROM unhackable where {name = }")
```
…elationship'), still some todo's for test coverage
Member
Author
|
pydal and psycopg2 have been updated to support python 3.14, meaning this PR can be merged and TypeDAL 4.0 can be released! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.14 works, but required some workarounds.
I have updated the annotation parsing logic for the new
annotationlib.urllib.FancyURLopenerwhich is deprecatedpsycopg2-binarydoesn't have prebuilt wheels for 3.14 yet (uv pip install https://github.com/trialandsuccess/psycopg2-python314/releases/download/psycopg2-2.9.10-cp314-cp314-linux_x86_64-rc2/psycopg2-2.9.10-cp314-cp314-linux_x86_64.whl)other Changes
.join()now supports nested relationships: e.g.Article.join("author.articles")to get the article with its author and all articles by that author. (you would access this likearticle.author.articles)core.pyhas been split up into multiple files to seperate concerns better. External exports are not affected but direct imports fromtypedal.corecould stop working.This PR also drops Python 3.10 support since keeping such a wide range of compatibility makes it hard to work with.
Due to the last two changes which could be potentially breaking, we will conservatively bump this next version to 4.0