generate and package jni lib in jar + load lib from jar without assuming it in java.library.path #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't use artifact as it as:
When we build circe-crc32c-sse42 using maven build:
jnilibrary under.narartifact. e.g:circe-crc32c-sse42.narNarSystem.javawhich tries to load thisjnilibrary at runtime usingSystem.loadLibrary("circe-crc32c-sse42-0.1-SNAPSHOT");which fails obviously because it asksClassLoaderto load library fromjava.library.pathorsun.boot.library.path. And as thisjnilibrary is packaged under.narso, definitely it is not present in eitherlibrary.pathand hence, initialization of the interface which provides API to compute checksum Sse42Crc32C.java fails.Solution
circe-crc32c-sse42.jarinsteadcirce-crc32c-sse42.narartifact and internally loads generatedjnilibrary without messing up withlibrary.pathand user can use this artifact without performing any additional magic.I have also added a test case which cleanly uses
Sse42Crc32C.javato compute checksum by simply adding dependency of artifactcom.scurrilous:circe-crc32c-sse42:${project.version}and without worrying about configuringlibrary.path.