Fixed double-free when destroying a copied Tlsh instance#90
Open
maikemoto wants to merge 1 commit intotrendmicro:masterfrom
Open
Fixed double-free when destroying a copied Tlsh instance#90maikemoto wants to merge 1 commit intotrendmicro:masterfrom
maikemoto wants to merge 1 commit intotrendmicro:masterfrom
Conversation
# Summary Sometimes, double-free occurs when destroying a copied Tlsh instance. A cause of the issue is when the Tlsh instance is assigned to another instance, default TlshImpl's operator=() method copies dynamically allocated memory areas by shallow copy. Therefore, when both copy source and copy destination are freed, same areas are freed twice. This change solves the issue by copying the areas by deep copy, and makes Tlsh instances copyable. # Changes Implement operator=(const TlshImpl&) method in the Tlsh class. The method allocates/frees dynamically allocated memory areas as necessary, and then copies data from source instance by deep copy. # Remark TlshImpl's copy constructor has the same issue. However, the constructor is never used, so there is unnecessary to implement it. # Reproduction code of the issue ``` Tlsh* tlsh[5]; tlsh[0] = new Tlsh(); tlsh[1] = new Tlsh(*tlsh[0]); for (unsigned char i = 0; i < 255; ++i) tlsh[0]->update(&i, 1); tlsh[2] = new Tlsh(*tlsh[0]); tlsh[0]->final(); tlsh[3] = new Tlsh(*tlsh[0]); tlsh[0]->getHash(); tlsh[4] = new Tlsh(*tlsh[0]); delete tlsh[0]; // success. delete tlsh[1]; // success. delete tlsh[2]; // failed because tlsh1->a_bucket is double-freed. delete tlsh[3]; // success. delete tlsh[4]; // failed because tlsh1->lsh_code is double-freed. ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sometimes, double-free occurs when destroying a copied Tlsh instance.
A cause of the issue is when the Tlsh instance is assigned to another instance, default TlshImpl's operator=() method copies dynamically allocated memory areas by shallow copy. Therefore, when both copy source and copy destination are freed, same areas are freed twice.
This change solves the issue by copying the areas by deep copy, and makes Tlsh instances copyable.
Changes
Implement operator=(const TlshImpl&) method in the Tlsh class. The method allocates/frees dynamically allocated memory areas as necessary, and then copies data from source instance by deep copy.
Remark
TlshImpl's copy constructor has the same issue. However, the constructor is never used, so there is unnecessary to implement it.
Reproduction code of the issue