Skip to content

Improve portability, add shared library build, install tlsh_unittest#107

Closed
cgull wants to merge 6 commits intotrendmicro:masterfrom
cgull:shlib-improvements-20210803
Closed

Improve portability, add shared library build, install tlsh_unittest#107
cgull wants to merge 6 commits intotrendmicro:masterfrom
cgull:shlib-improvements-20210803

Conversation

@cgull
Copy link
Contributor

@cgull cgull commented Sep 4, 2021

These changes are for using tlsh on a vendored FreeBSD, using CMake directly, but should improve portability in general.

  • Version the shared library; make it a no-edit build option.
  • Make the shell scripts portable.
  • Rename to tlsh_version.h, etc to avoid conflicts with other similarly named files.
  • Install tlsh_unittest, its ability to generate a hash on a file is generally useful.
  • Create symlinks for tlsh with CMake instead of make.sh. This helps for environments that use CMake directly.

Make it possible to build shared libraries without source edits.
Use the major version number on major-version-only solib name.
Change make.sh to use the new variable.
This allows us to reuse the name for the tlsh symlink/executable.
@jonjoliver
Copy link
Collaborator

Thank you - this has been merged as version 4.8.1

I could not just do the pull request
I had to merge some conflicts

@jonjoliver
Copy link
Collaborator

Hi cgull

mapreri has suggested pull request #110
I want to make sure that it does not break your install
Could you look at pull request #110 and comment?

Cheers
jono

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments