Conversation
… decrement and that's mine
…in .tool-versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
element/2function plays another central role as it allows you to extract DOM elements from the view and select them very specifically usinghas_element?/3.Included in this commit are two examples of not so good practice and one of my own tests for ensuring clicking the decrement button does actually decrement html in the view.
Also, I'll be tagging tests with one of three tags
:good- tags for best practice and how LiveView tests should be structured:ungood- tags for how not to approach testing becasue it leads to false positives or sloppy assumptions:mine- I wrote the test.Also matched version of Elixir in GH actions file with the version in the asdf
.tool-versionfilecloses #19