This repository was archived by the owner on Jul 3, 2023. It is now read-only.
Remove code that improperly calls pool_unread#51
Open
atokhy wants to merge 1 commit intotreasure-data:masterfrom
Open
Remove code that improperly calls pool_unread#51atokhy wants to merge 1 commit intotreasure-data:masterfrom
atokhy wants to merge 1 commit intotreasure-data:masterfrom
Conversation
Presto queries may result in outputs that contain multiple \0 or NULL characters. As a result, a single error message or notice may contain multiple \0 delimited strings which would get read at once on invocation to per_node_error_log(), which then attempts to 'unread' the contents it just read. However, the pool_unread invocation ends up unreading up to the first \0 character, and it does not unread the full message, causing subsequent calls to getting the postgres message kind to fail as the kind ends up being a \0 character.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presto queries may result in outputs that contain multiple
\0 or NULL characters. As a result, a single error
message or notice may contain multiple \0 delimited
strings which would get read at once on invocation to
per_node_error_log(), which then attempts to 'unread'
the contents it just read. However, the pool_unread invocation
ends up unreading up to the first \0 character, and it
does not unread the full message, causing subsequent
calls to getting the postgres message kind to fail
as the kind ends up being a \0 character.