This repository was archived by the owner on May 10, 2018. It is now read-only.
Add conditional for library that wont build on Ruby 2.0#565
Closed
bnferguson wants to merge 1 commit intomasterfrom
Closed
Add conditional for library that wont build on Ruby 2.0#565bnferguson wants to merge 1 commit intomasterfrom
bnferguson wants to merge 1 commit intomasterfrom
Conversation
|
Apparently this issue which this PR fixes is blocking #562 and therefore blocking travis-ci/travis-tasks#71. I would love to see #562 being merged. What's preventing the checks in this PR from passing? |
Contributor
Author
|
AFAIK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Already did this in the
enterprise-2.0branch but realized I should have done it first in master and ported it back instead so things like #563 can make it into master in case we need another round oftravis-corein Enterprise.