Skip to content

Add iSCSI ICL kobj to MFILES list#1

Open
ctuffli wants to merge 1 commit intotrasz:masterfrom
ctuffli:master
Open

Add iSCSI ICL kobj to MFILES list#1
ctuffli wants to merge 1 commit intotrasz:masterfrom
ctuffli:master

Conversation

@ctuffli
Copy link

@ctuffli ctuffli commented Dec 13, 2014

Change allows more common convention of adding icl_conn_if.h to SRCS in Makefile

Signed-off-by: Chuck Tuffli chuck@tuffli.net

Signed-off-by: Chuck Tuffli <chuck@tuffli.net>
@trasz
Copy link
Owner

trasz commented Feb 8, 2015

Hi. Looking at the tree, there are about as many uses for either convention - ie adding whatever_if.m files to sys/conf/kmod.mk vs adding it to sys/modules/whatever/Makefile. Also, icl_conn_if.h already is there in sys/modules/{iscsi,ctl}/Makefile. So, can you explain what this change is for? Thanks!

@ctuffli
Copy link
Author

ctuffli commented Mar 1, 2015

Many driver Makefiles create interfaces headers such as BUS and DEVICE by adding the header file to SRCS:

SRCS = \
    device_if.h \
    bus_if.h \
    pci_if.h

By adding icl_conn_if.m to the default MFILES definition, external ICL drivers could add the ICL interface to the above using

SRCS += icl_conn_if.h

Without this change, driver Makefiles must explicitly specify all MFILES values:

MFILES = \
    device_if.m \
    bus_if.m \
    pci_if.m \
    icl_conn_if.m

They cannot simply specify MFILES += icl_conn_if.m due to the mk file inclusion order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants