Skip to content

Conversation

@khaeru
Copy link
Contributor

@khaeru khaeru commented Dec 27, 2025

sdmx1 version 2.24.0 was released 2025-12-18. It obviates some fixes included here, but also adjusts the default behaviour for incrementing versions. This PR adjusts.

Also:

  • Zenodo recently tightened rate limits for some API actions; see here. This causes some tests to be flaky: if the ratelimit is hit, all subsequent queries to the API fail.
    The PR works around this issue by retrying with a delay. A more robust fix would be to rate limit the requests in the code itself.

PR checklist

  • Checks all ✅
  • Update documentation
  • Update doc/whatsnew.rst

Resolved upstream in sdmx1 v2.24.0 or earlier.
Handle "(None)" in URNs parsed to the string "None".
- Fix the version of this artefact in the code. This avoids
  non-deterministic versions if the function is called multiple times.
- Adjust usage in "org refresh" CLI command.
@codecov
Copy link

codecov bot commented Dec 28, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.12%. Comparing base (09ecca7) to head (1016e39).

Files with missing lines Patch % Lines
transport_data/util/pooch.py 92.30% 6 Missing ⚠️
transport_data/tests/test_store.py 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   94.13%   91.12%   -3.01%     
==========================================
  Files          65       65              
  Lines        3016     3427     +411     
==========================================
+ Hits         2839     3123     +284     
- Misses        177      304     +127     
Files with missing lines Coverage Δ
transport_data/ato/cli.py 87.50% <100.00%> (+0.83%) ⬆️
transport_data/org/__init__.py 100.00% <100.00%> (ø)
transport_data/org/cli.py 97.29% <100.00%> (-0.04%) ⬇️
transport_data/store.py 74.28% <100.00%> (-25.72%) ⬇️
transport_data/testing/__init__.py 100.00% <ø> (ø)
transport_data/tests/org/test_metadata.py 100.00% <100.00%> (ø)
transport_data/tests/test_ato.py 100.00% <100.00%> (ø)
transport_data/tests/test_store.py 94.23% <57.14%> (-5.77%) ⬇️
transport_data/util/pooch.py 94.28% <92.30%> (-5.72%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Override DOIDownloader.__call__().
- Override Pooch.load_registry_from_doi().
- Override ZenodoRepository.api_response.
- Override doi_to_{repository,url}().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enh New feature or request

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants