-
Notifications
You must be signed in to change notification settings - Fork 1
Adjust for sdmx1 v2.24.0 #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
khaeru
wants to merge
9
commits into
main
Choose a base branch
from
enh/sdmx-2.24
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved upstream in sdmx1 v2.24.0 or earlier.
Handle "(None)" in URNs parsed to the string "None".
74d74c0 to
3663b2c
Compare
3663b2c to
e1d193e
Compare
e1d193e to
546df3b
Compare
- Fix the version of this artefact in the code. This avoids non-deterministic versions if the function is called multiple times. - Adjust usage in "org refresh" CLI command.
546df3b to
110b750
Compare
0934ebf to
f271bf8
Compare
f271bf8 to
e320deb
Compare
e320deb to
6f1d2b4
Compare
6f1d2b4 to
f3585dd
Compare
8f18acd to
1c15593
Compare
1c15593 to
8b633df
Compare
8b633df to
d90c267
Compare
d90c267 to
fa3fc00
Compare
fa3fc00 to
a953f9e
Compare
a953f9e to
40efd28
Compare
40efd28 to
e5f7cd2
Compare
e5f7cd2 to
1016e39
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
==========================================
- Coverage 94.13% 91.12% -3.01%
==========================================
Files 65 65
Lines 3016 3427 +411
==========================================
+ Hits 2839 3123 +284
- Misses 177 304 +127
🚀 New features to boost your workflow:
|
- Cache retrieved test data.
- Override DOIDownloader.__call__().
- Override Pooch.load_registry_from_doi().
- Override ZenodoRepository.api_response.
- Override doi_to_{repository,url}().
1016e39 to
d9a4014
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sdmx1version 2.24.0 was released 2025-12-18. It obviates some fixes included here, but also adjusts the default behaviour for incrementing versions. This PR adjusts.Also:
The PR works around this issue by retrying with a delay. A more robust fix would be to rate limit the requests in the code itself.
PR checklist
Update documentation