Skip to content

companion: port to TypeScript#6179

Open
kvz wants to merge 5 commits intomainfrom
ts-companion-renames
Open

companion: port to TypeScript#6179
kvz wants to merge 5 commits intomainfrom
ts-companion-renames

Conversation

@kvz
Copy link
Member

@kvz kvz commented Feb 11, 2026

Supersedes #6178.

This branch keeps the exact same final content as #6178, but splits history for reviewability:

  1. chore(companion): rename source and test files from .js to .ts (pure git mv, no content changes)
  2. feat(companion): port Companion to TypeScript (actual content/type/schema/build updates)

Validation note:

  • Final tree is byte-for-byte identical to ts-companion (7b5b16a298690b0492de4cc4fab744f998b45570).

@changeset-bot
Copy link

changeset-bot bot commented Feb 11, 2026

⚠️ No Changeset found

Latest commit: 45f32fe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kvz kvz self-assigned this Feb 11, 2026
@kvz kvz requested review from Murderlon and mifi February 11, 2026 07:21
@@ -1,3 +0,0 @@
#!/usr/bin/env node
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new bin points to dist/

run:
corepack yarn install
- run: corepack yarn run typecheck
- run: corepack yarn workspace @uppy/companion lint:ts
Copy link
Member Author

@kvz kvz Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra strict typescript options, but just for linting, as to remain compatible with status quo outputs for now

@Murderlon
Copy link
Member

I ran it through Devin Review, it has some comments: https://app.devin.ai/review/transloadit/uppy/pull/6179

@socket-security
Copy link

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm ioredis is 96.0% likely obfuscated

Confidence: 0.96

Location: Package overview

From: packages/@uppy/companion/package.jsonnpm/ioredis@5.7.0

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/ioredis@5.7.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@kvz
Copy link
Member Author

kvz commented Feb 11, 2026

I ran it through Devin Review, it has some comments: https://app.devin.ai/review/transloadit/uppy/pull/6179

That was helpful! Added the patches to address. Also kicked another review and added patches for the findings then. Each time covered by added regression tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants