Conversation
|
| @@ -1,3 +0,0 @@ | |||
| #!/usr/bin/env node | |||
| run: | ||
| corepack yarn install | ||
| - run: corepack yarn run typecheck | ||
| - run: corepack yarn workspace @uppy/companion lint:ts |
There was a problem hiding this comment.
Extra strict typescript options, but just for linting, as to remain compatible with status quo outputs for now
|
I ran it through Devin Review, it has some comments: https://app.devin.ai/review/transloadit/uppy/pull/6179 |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
That was helpful! Added the patches to address. Also kicked another review and added patches for the findings then. Each time covered by added regression tests. |
Supersedes #6178.
This branch keeps the exact same final content as #6178, but splits history for reviewability:
chore(companion): rename source and test files from .js to .ts(puregit mv, no content changes)feat(companion): port Companion to TypeScript(actual content/type/schema/build updates)Validation note:
ts-companion(7b5b16a298690b0492de4cc4fab744f998b45570).