Import django_bulk_update instead of bulk_update #6793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@erosennin looks good - but im wondering if we need to bump requirements to ensure that pootle uses the newer version of bulk update |
Author
|
@phlax looks like we already have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module name of django-bulk-update has changed from
bulk_updatetodjango_bulk_updatein version 2.0.0 (see changelog). Pootle still uses the old package name. This still works most of the time, becausedjango_bulk_update-2.2.0-py2.py3-none-any.whlon PyPI includes the oldbulk_updatemodule for backward compatibility. However, the source tree of django-bulk-update does not contain thebulk_updatemodule anymore, and Pootle currently won't work if django-bulk-update is installed from source. This PR fixes that.