Skip to content

Conversation

@nfebe
Copy link
Contributor

@nfebe nfebe commented Dec 31, 2025

No description provided.

Resolve dashboard not loading after refresh due to i18n context issue.
Add translatable auth carousel slides to all locales.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
Middleware now only redirects FROM onboarding if already complete.
Dashboard checks onboarding status after data loads before redirecting.
Add useOnboardingStatus composable for consistent cookie handling.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
ContentCard props and LineChartCard loop variable.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
@cloudflare-workers-and-pages
Copy link

Deploying webui with  Cloudflare Pages  Cloudflare Pages

Latest commit: 64063e2
Status: ✅  Deploy successful!
Preview URL: https://0143d4c5.webui-9fh.pages.dev
Branch Preview URL: https://fix-i18n-data-initialization.webui-9fh.pages.dev

View logs

@sourceant
Copy link

sourceant bot commented Dec 31, 2025

Code Review Summary

This pull request introduces significant enhancements to the application's onboarding process and internationalization. A new useOnboardingStatus composable centralizes onboarding state management, leading to a more robust and maintainable flow across login, dashboard, and the onboarding wizard itself. Internationalization has been extended to the authentication carousel, and default prop values have been added for increased component stability. Minor bug fixes and readability improvements are also included.

🚀 Key Improvements

  • Centralized Onboarding Logic: The introduction of composables/useOnboardingStatus.ts consolidates onboarding state and logic, making the flow more manageable and consistent.
  • Enhanced Internationalization: The AuthCarousel is now fully internationalized, and useDataManager handles language preferences more robustly via cookies.
  • Improved Prop Definitions: components/ContentCard.vue now uses more explicit prop definitions with default values, enhancing component reliability.

💡 Minor Suggestions

  • Consider more explicit error logging in pages/onboarding.vue's onBeforeRouteLeave hook to capture potential issues with onboarding completion API calls.
  • Clarify the necessity of resetAuthMiddlewareState in middleware/auth.ts if it's currently a no-op.
  • Review the httpOnly setting for the auth.token cookie if client-side JavaScript access is not strictly required, to improve security against XSS.

Copy link

@sourceant sourceant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. No specific code suggestions were generated. See the overview comment for a summary.

@nfebe nfebe merged commit 3ce5842 into main Dec 31, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants