fix: Syncrhonization bugs and improvements on transaction form

[nfebe]

Syncrhonization bugs and improvements on transaction form

[sourceant]

Code Review Summary

This pull request introduces several important improvements across the synchronization core and related UI components. Key enhancements include robust error handling, efficient data fetching through pagination, improved dependency sorting for local changes, and better consistency in UI interactions when adding new entities. The overall changes make the synchronization process more reliable, performant, and maintainable.

🚀 Key Improvements

• Implemented pagination in all *RemoteDataSource getAll* methods, drastically improving performance and resource management for large datasets.
• Ensured proper awaiting of SynchAppDatabase().doSync() calls in AppWidget and OnboardSettingsScreen for reliable synchronization flow.
• Improved dependency sorting for PendingLocalChange entities in DriftSynchronizer's uploadLocalChanges, ensuring entities are uploaded in the correct order based on their relationships.
• Fixed a critical bug in CategorySyncHandler.getLocalByClientId that caused a recursive call, replacing it with a correct database query.
• Enhanced user experience in AddTransactionForm by automatically updating selected wallets, parties, and categories after adding new ones, and filtering available wallets by selected currency.

💡 Minor Suggestions

• While the ConfigSyncHandler currently uses an int for TServerKey and converts it to String for remote calls, a refactoring to declare TServerKey as String directly would provide better type consistency and clarity, as configuration entities are primarily identified by a String key remotely.

[sourceant]

🔍 Code Review

💡 1. **lib/data/sync/config_sync_handler.dart** (Lines 57-59) - REFACTOR

Following the change of TServerKey to String for ConfigSyncHandler, the restGetRemote method signature must be updated to accept a String identifier, aligning with the ConfigRemoteDataSource's getConfig(String key) method.

Suggested Code:

  @override
  Future<Config?> restGetRemote(String key) async {
    return await remoteDataSource.getConfig(key);
  }

Current Code:

  @override
  Future<Config?> restGetRemote(int id) async {
      // return await remoteDataSource.getConfig(id);
    return await remoteDataSource.getConfig(id.toString());
  }

Verdict: APPROVE

Posted as a comment because posting a review failed.

[sourceant]

Review complete. See the overview comment for a summary.

[sourceant]

Review complete. See the overview comment for a summary.