Fix second-opinion schema validation and update Gemini to 3.1#103
Merged
Fix second-opinion schema validation and update Gemini to 3.1#103
Conversation
codex-review-schema.json failed OpenAI structured output validation because required arrays didn't include all sibling property keys when additionalProperties: false was set. Made optional fields nullable and added them to required to satisfy the constraint. Update Gemini model from gemini-3-pro-preview to gemini-3.1-pro-preview following the Feb 19 release. Bump version 1.5.0 → 1.5.1. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex-review-schema.jsonfailing OpenAI structured output validation —requiredarrays now include all sibling property keys as mandated whenadditionalProperties: falseis set. Optional fields (confidence_score,code_location,line_range,overall_explanation) are made nullable so they can returnnullinstead of being omitted.gemini-3-pro-previewtogemini-3.1-pro-previewfollowing the Feb 19 release.Test plan
codex exec --output-schema codex-review-schema.jsonagainst gpt-5.3-codex — should no longer fail withinvalid_json_schema/second-opinion— confirm it invokesgemini-3.1-pro-previewpython -c "import json; json.load(open('plugins/second-opinion/skills/second-opinion/references/codex-review-schema.json'))"🤖 Generated with Claude Code