Skip to content

Bump pack versions, and fix NamedType #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mschwager wants to merge 3 commits into from
Closed

Bump pack versions, and fix NamedType #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79de598
Bump pack versions, and fix NamedType
mschwager Sep 11, 2025
af09db8
Verbose testing
mschwager Sep 11, 2025
f4c4101
Try manual codeql installation
mschwager Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,11 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- id: init
uses: github/codeql-action/init@v3
- name: Run tests
run: |
${{ steps.init.outputs.codeql-path }} test run ./cpp/test/
${{ steps.init.outputs.codeql-path }} test run ./go/test/
${{ steps.init.outputs.codeql-path }} test run ./java/test/
wget https://github.com/github/codeql-cli-binaries/releases/download/v2.23.0/codeql-linux64.zip
unzip codeql-linux64.zip
./codeql/codeql --version
./codeql/codeql pack install ./java/src/
./codeql/codeql pack install ./java/test/
./codeql/codeql test run -vvv ./java/test/
24 changes: 21 additions & 3 deletions cpp/lib/codeql-pack.lock.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,28 @@
---
lockVersion: 1.0.0
dependencies:
codeql/controlflow:
version: 2.0.14
codeql/cpp-all:
version: 0.6.1
version: 5.5.0
codeql/dataflow:
version: 2.0.14
codeql/mad:
version: 1.0.30
codeql/quantum:
version: 0.0.8
codeql/rangeanalysis:
version: 1.0.30
codeql/ssa:
version: 0.0.14
version: 2.0.6
codeql/tutorial:
version: 0.0.7
version: 1.0.30
codeql/typeflow:
version: 1.0.30
codeql/typetracking:
version: 2.0.14
codeql/util:
version: 2.0.17
codeql/xml:
version: 1.0.30
compiled: false
24 changes: 14 additions & 10 deletions cpp/src/codeql-pack.lock.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,28 @@
---
lockVersion: 1.0.0
dependencies:
codeql/controlflow:
version: 2.0.14
codeql/cpp-all:
version: 3.0.0
version: 5.5.0
codeql/dataflow:
version: 1.1.7
version: 2.0.14
codeql/mad:
version: 1.0.13
version: 1.0.30
codeql/quantum:
version: 0.0.8
codeql/rangeanalysis:
version: 1.0.13
version: 1.0.30
codeql/ssa:
version: 1.0.13
version: 2.0.6
codeql/tutorial:
version: 1.0.13
version: 1.0.30
codeql/typeflow:
version: 1.0.13
version: 1.0.30
codeql/typetracking:
version: 1.0.13
version: 2.0.14
codeql/util:
version: 2.0.0
version: 2.0.17
codeql/xml:
version: 1.0.13
version: 1.0.30
compiled: false
24 changes: 14 additions & 10 deletions cpp/test/codeql-pack.lock.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,28 @@
---
lockVersion: 1.0.0
dependencies:
codeql/controlflow:
version: 2.0.14
codeql/cpp-all:
version: 3.0.0
version: 5.5.0
codeql/dataflow:
version: 1.1.7
version: 2.0.14
codeql/mad:
version: 1.0.13
version: 1.0.30
codeql/quantum:
version: 0.0.8
codeql/rangeanalysis:
version: 1.0.13
version: 1.0.30
codeql/ssa:
version: 1.0.13
version: 2.0.6
codeql/tutorial:
version: 1.0.13
version: 1.0.30
codeql/typeflow:
version: 1.0.13
version: 1.0.30
codeql/typetracking:
version: 1.0.13
version: 2.0.14
codeql/util:
version: 2.0.0
version: 2.0.17
codeql/xml:
version: 1.0.13
version: 1.0.30
compiled: false
18 changes: 10 additions & 8 deletions go/src/codeql-pack.lock.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,22 @@
---
lockVersion: 1.0.0
dependencies:
codeql/controlflow:
version: 2.0.14
codeql/dataflow:
version: 1.1.7
version: 2.0.14
codeql/go-all:
version: 3.0.0
version: 4.3.3
codeql/mad:
version: 1.0.13
version: 1.0.30
codeql/ssa:
version: 1.0.13
version: 2.0.6
codeql/threat-models:
version: 1.0.13
version: 1.0.30
codeql/tutorial:
version: 1.0.13
version: 1.0.30
codeql/typetracking:
version: 1.0.13
version: 2.0.14
codeql/util:
version: 2.0.0
version: 2.0.17
compiled: false
6 changes: 3 additions & 3 deletions go/src/security/MissingMinVersionTLS/MissingMinVersionTLS.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,12 @@ predicate configOrConfigPointer(Type t) {
) or
exists(Type tp |
tp.hasQualifiedName("crypto/tls", "Config") and
t.(NamedType).getUnderlyingType().(StructType).hasField(_, tp)
t.(DefinedType).getUnderlyingType().(StructType).hasField(_, tp)
) or
exists(Type tp, Type tp2 |
tp.hasQualifiedName("crypto/tls", "Config") and
tp2 = tp.getPointerType+() and
t.(NamedType).getUnderlyingType().(StructType).hasField(_, tp2)
t.(DefinedType).getUnderlyingType().(StructType).hasField(_, tp2)
)
}

Expand Down Expand Up @@ -149,4 +149,4 @@ where
) else
any()

select configStruct, "TLS.Config.MinVersion is never set for variable $@ ", v, v.getName()
select configStruct, "TLS.Config.MinVersion is never set for variable $@ ", v, v.getName()
18 changes: 10 additions & 8 deletions go/test/codeql-pack.lock.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,22 @@
---
lockVersion: 1.0.0
dependencies:
codeql/controlflow:
version: 2.0.14
codeql/dataflow:
version: 1.1.7
version: 2.0.14
codeql/go-all:
version: 3.0.0
version: 4.3.3
codeql/mad:
version: 1.0.13
version: 1.0.30
codeql/ssa:
version: 1.0.13
version: 2.0.6
codeql/threat-models:
version: 1.0.13
version: 1.0.30
codeql/tutorial:
version: 1.0.13
version: 1.0.30
codeql/typetracking:
version: 1.0.13
version: 2.0.14
codeql/util:
version: 2.0.0
version: 2.0.17
compiled: false
28 changes: 16 additions & 12 deletions java/src/codeql-pack.lock.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,32 @@
---
lockVersion: 1.0.0
dependencies:
codeql/controlflow:
version: 2.0.14
codeql/dataflow:
version: 1.1.5
version: 2.0.14
codeql/java-all:
version: 4.2.0
version: 7.6.1
codeql/mad:
version: 1.0.11
version: 1.0.30
codeql/quantum:
version: 0.0.8
codeql/rangeanalysis:
version: 1.0.11
version: 1.0.30
codeql/regex:
version: 1.0.11
version: 1.0.30
codeql/ssa:
version: 1.0.11
version: 2.0.6
codeql/threat-models:
version: 1.0.11
version: 1.0.30
codeql/tutorial:
version: 1.0.11
version: 1.0.30
codeql/typeflow:
version: 1.0.11
version: 1.0.30
codeql/typetracking:
version: 1.0.11
version: 2.0.14
codeql/util:
version: 1.0.11
version: 2.0.17
codeql/xml:
version: 1.0.11
version: 1.0.30
compiled: false
28 changes: 16 additions & 12 deletions java/test/codeql-pack.lock.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,32 @@
---
lockVersion: 1.0.0
dependencies:
codeql/controlflow:
version: 2.0.14
codeql/dataflow:
version: 1.1.5
version: 2.0.14
codeql/java-all:
version: 4.2.0
version: 7.6.1
codeql/mad:
version: 1.0.11
version: 1.0.30
codeql/quantum:
version: 0.0.8
codeql/rangeanalysis:
version: 1.0.11
version: 1.0.30
codeql/regex:
version: 1.0.11
version: 1.0.30
codeql/ssa:
version: 1.0.11
version: 2.0.6
codeql/threat-models:
version: 1.0.11
version: 1.0.30
codeql/tutorial:
version: 1.0.11
version: 1.0.30
codeql/typeflow:
version: 1.0.11
version: 1.0.30
codeql/typetracking:
version: 1.0.11
version: 2.0.14
codeql/util:
version: 1.0.11
version: 2.0.17
codeql/xml:
version: 1.0.11
version: 1.0.30
compiled: false
Loading