Skip to content

Fix trim misuse df #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GrosQuildu merged 2 commits into from
Dec 18, 2024
Merged

Fix trim misuse df #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18d3204
fix trim misuse
GrosQuildu Dec 17, 2024
6381cb5
fix pack locks
GrosQuildu Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion cpp/src/codeql-pack.lock.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,24 @@
---
lockVersion: 1.0.0
dependencies: {}
dependencies:
codeql/cpp-all:
version: 3.0.0
codeql/dataflow:
version: 1.1.7
codeql/mad:
version: 1.0.13
codeql/rangeanalysis:
version: 1.0.13
codeql/ssa:
version: 1.0.13
codeql/tutorial:
version: 1.0.13
codeql/typeflow:
version: 1.0.13
codeql/typetracking:
version: 1.0.13
codeql/util:
version: 2.0.0
codeql/xml:
version: 1.0.13
compiled: false
22 changes: 21 additions & 1 deletion cpp/test/codeql-pack.lock.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,24 @@
---
lockVersion: 1.0.0
dependencies: {}
dependencies:
codeql/cpp-all:
version: 3.0.0
codeql/dataflow:
version: 1.1.7
codeql/mad:
version: 1.0.13
codeql/rangeanalysis:
version: 1.0.13
codeql/ssa:
version: 1.0.13
codeql/tutorial:
version: 1.0.13
codeql/typeflow:
version: 1.0.13
codeql/typetracking:
version: 1.0.13
codeql/util:
version: 2.0.0
codeql/xml:
version: 1.0.13
compiled: false
18 changes: 17 additions & 1 deletion go/src/codeql-pack.lock.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,20 @@
---
lockVersion: 1.0.0
dependencies: {}
dependencies:
codeql/dataflow:
version: 1.1.7
codeql/go-all:
version: 3.0.0
codeql/mad:
version: 1.0.13
codeql/ssa:
version: 1.0.13
codeql/threat-models:
version: 1.0.13
codeql/tutorial:
version: 1.0.13
codeql/typetracking:
version: 1.0.13
codeql/util:
version: 2.0.0
compiled: false
4 changes: 2 additions & 2 deletions go/src/security/TrimMisuse/TrimMisuse.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
*/

import go
import DataFlow2
import semmle.go.dataflow.DataFlow

/*
* Flows from a string to TrimFamilyCall cutSet argument
Expand All @@ -32,7 +32,7 @@ module Trim2ndArgFlow = DataFlow::Global<Trim2ndArgConfig>;
/*
* Calls to Trim methods that we are interested in
*/
class TrimFamilyCall extends CallNode {
class TrimFamilyCall extends DataFlow::CallNode {
TrimFamilyCall() {
this.getTarget().hasQualifiedName("strings", ["TrimRight", "TrimLeft", "Trim"])
or
Expand Down
18 changes: 17 additions & 1 deletion go/test/codeql-pack.lock.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,20 @@
---
lockVersion: 1.0.0
dependencies: {}
dependencies:
codeql/dataflow:
version: 1.1.7
codeql/go-all:
version: 3.0.0
codeql/mad:
version: 1.0.13
codeql/ssa:
version: 1.0.13
codeql/threat-models:
version: 1.0.13
codeql/tutorial:
version: 1.0.13
codeql/typetracking:
version: 1.0.13
codeql/util:
version: 2.0.0
compiled: false
Loading