Skip to content

Fix tag value filtering #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmattheis merged 2 commits into from
Jan 8, 2026
Merged

Fix tag value filtering #231

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f05b3db
fix: filtering of tag values
jmattheis Jan 8, 2026
b7f2619
fix: always invalidate suggest result
jmattheis Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ui/src/tag/suggest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,13 @@ export const useSuggest = (
const valueResult = useQuery<SuggestTagValue, SuggestTagValueVariables>(gqlTags.SuggestTagValue, {
variables: {tag: tagKey, query: tagValue},
skip: exactMatch === undefined || skipValue,
fetchPolicy: 'no-cache',
});

const usedKeys = usedTags.map((t) => t.tag.key);
const usedValues = usedTags.map((t) => t.value);

if (exactMatch && tagValue !== undefined && !skipValue && (allowDuplicateKeys || usedKeys.indexOf(exactMatch.key) === -1)) {
const usedValues = usedTags.filter((t) => t.tag.key === tagKey).map((t) => t.value);
return suggestTagValue(exactMatch, tagValue, valueResult, usedValues, createTags);
} else {
return suggestTag(exactMatch, tagResult, tagKey, usedKeys, allowDuplicateKeys, createTags);
Expand Down
Loading