Fix user selection dropdown hover when multiple users have same name#388
Merged
Fix user selection dropdown hover when multiple users have same name#388
Conversation
Previously, the email was hidden when the user's display name was being edited. Restructured the layout to always display email below the display name/edit controls.
Display email alongside display name in both the user search dropdown and the selected user display on the cohort page.
Use user ID as the Command.Item value instead of display_name to ensure each item is uniquely identifiable, preventing both items from being highlighted when they share the same name.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix an issue where hovering over users in the cohort member selection dropdown would highlight multiple items if they shared the same display name.
Root Cause
The Command.Item was using
value={user.display_name}which caused conflicts when multiple users had identical names—the dropdown library would match and highlight all items with the same value.Solution
Use the unique user ID as the value instead, ensuring each dropdown item is independently identifiable.
Test plan