Skip to content

Constrain initial balance inputs to numeric values #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
briansmiley merged 2 commits into from
Apr 13, 2026
+11 −5
Merged

Constrain initial balance inputs to numeric values #383

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92711f9
Constrain initial balance inputs to numeric values on admin cohort page
briansmiley Apr 13, 2026
91c892c
Fix .trim() on number inputs — convert to String() instead
briansmiley Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions frontend/src/routes/admin/cohorts/[name]/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@
const opts: { user_ids: number[]; initial_balance?: string } = {
user_ids: [selectedUserId]
};
if (userInitialBalance.trim()) {
opts.initial_balance = userInitialBalance.trim();
if (userInitialBalance !== '') {
opts.initial_balance = String(userInitialBalance);
}
const result = await batchAddMembers(cohortName, opts);
toast.success(`Added ${result.added} member`);
Expand All @@ -137,8 +137,8 @@
if (emails.length === 0) return;
try {
const opts: { emails: string[]; initial_balance?: string } = { emails };
if (emailInitialBalance.trim()) {
opts.initial_balance = emailInitialBalance.trim();
if (emailInitialBalance !== '') {
opts.initial_balance = String(emailInitialBalance);
}
const result = await batchAddMembers(cohortName, opts);
toast.success(`Added ${result.added} members`);
Expand Down Expand Up @@ -167,7 +167,7 @@

async function saveEditingBalance() {
if (editingMemberId == null) return;
const value = editingBalance.trim() || null;
const value = editingBalance !== '' ? String(editingBalance) : null;
try {
await updateMemberInitialBalance(cohortName, editingMemberId, value);
const member = members.find((m) => m.id === editingMemberId);
Expand Down Expand Up @@ -271,6 +271,8 @@
</Popover.Content>
</Popover.Root>
<input
type="number"
min="0"
class="w-40 rounded-md border bg-background px-3 py-2 text-sm"
placeholder="Initial balance"
bind:value={userInitialBalance}
Expand All @@ -296,6 +298,8 @@
></textarea>
<div class="mt-2 flex items-center gap-2">
<input
type="number"
min="0"
class="w-40 rounded-md border bg-background px-3 py-2 text-sm"
placeholder="Initial balance"
bind:value={emailInitialBalance}
Expand Down Expand Up @@ -345,6 +349,8 @@
{#if editingMemberId === member.id}
<div class="flex items-center gap-1">
<input
type="number"
min="0"
class="w-28 rounded-md border bg-background px-2 py-0.5 font-mono text-xs"
bind:value={editingBalance}
placeholder="initial bal"
Expand Down
Loading