Skip to content

Fix order form rejecting price=0 #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crthpl merged 1 commit into from
Mar 8, 2026
Merged

Fix order form rejecting price=0 #374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions frontend/src/lib/components/marketOrders.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,25 +189,28 @@
});
}

// Check if a form value has been filled in (handles 0 being falsy)
const hasValue = (v: string | number | null | undefined) => v !== '' && v != null;

// Clear errors when user types
$effect(() => {
if (bidPrice) bidPriceError = '';
if (hasValue(bidPrice)) bidPriceError = '';
});
$effect(() => {
if (bidSize) bidSizeError = '';
if (hasValue(bidSize)) bidSizeError = '';
});
$effect(() => {
if (offerPrice) offerPriceError = '';
if (hasValue(offerPrice)) offerPriceError = '';
});
$effect(() => {
if (offerSize) offerSizeError = '';
if (hasValue(offerSize)) offerSizeError = '';
});

// Check if an order would be taken by the current form input
const bidPriceNum = $derived(bidPrice ? Number(bidPrice) : null);
const bidSizeNum = $derived(bidSize ? Number(bidSize) : 1.0);
const offerPriceNum = $derived(offerPrice ? Number(offerPrice) : null);
const offerSizeNum = $derived(offerSize ? Number(offerSize) : 1.0);
const bidPriceNum = $derived(hasValue(bidPrice) ? Number(bidPrice) : null);
const bidSizeNum = $derived(hasValue(bidSize) ? Number(bidSize) : 1.0);
const offerPriceNum = $derived(hasValue(offerPrice) ? Number(offerPrice) : null);
const offerSizeNum = $derived(hasValue(offerSize) ? Number(offerSize) : 1.0);

// Compute which offers would be taken by the current bid (sorted by price ascending)
const takenOfferIds = $derived.by(() => {
Expand Down Expand Up @@ -246,8 +249,8 @@
});

// Check if forms are complete enough to submit
const bidFormIncomplete = $derived(!bidPrice || !bidSize);
const offerFormIncomplete = $derived(!offerPrice || !offerSize);
const bidFormIncomplete = $derived(!hasValue(bidPrice) || !hasValue(bidSize));
const offerFormIncomplete = $derived(!hasValue(offerPrice) || !hasValue(offerSize));

// Check if user has any orders to clear
const hasOwnBids = $derived(
Expand Down