Skip to content

Add progress bar to performance page during trade history loading #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crthpl merged 2 commits into from
Mar 8, 2026
Merged

Add progress bar to performance page during trade history loading #373

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8300e3
Add progress bar to performance page during trade history loading
crthpl Mar 8, 2026
6502627
Fix reactivity of loading progress bar on performance page
crthpl Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 20 additions & 7 deletions frontend/src/routes/performance/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<script lang="ts">
import { untrack } from 'svelte';
import { accountName, sendClientMessage, serverState } from '$lib/api.svelte';
import PnlChart from '$lib/components/pnlChart.svelte';
import PriceChart from '$lib/components/priceChart.svelte';
Expand Down Expand Up @@ -130,7 +131,7 @@
});

// --- Trade history loading ---
let requestedMarkets = new Set<number>();
let requestedMarkets = $state(new Set<number>());
let prevAccountId: number | undefined = undefined;

// Request trade history for relevant markets
Expand All @@ -155,7 +156,7 @@

let delay = 0;
for (const marketId of needed) {
if (requestedMarkets.has(marketId)) continue;
if (untrack(() => requestedMarkets.has(marketId))) continue;
requestedMarkets.add(marketId);
setTimeout(() => {
sendClientMessage({ getFullTradeHistory: { marketId } });
Expand Down Expand Up @@ -358,12 +359,24 @@
</script>

<div class="w-full pt-8">
<div class="mb-6 flex items-center justify-between">
<h1 class="text-xl font-bold">Performance</h1>
<div class="mb-6">
<div class="flex items-center justify-between">
<h1 class="text-xl font-bold">Performance</h1>
{#if isLoading}
<span class="text-sm text-muted-foreground">
Loading trade history: {loadingProgress.loaded}/{loadingProgress.total} markets...
</span>
{/if}
</div>
{#if isLoading}
<span class="text-sm text-muted-foreground">
Loading trade history: {loadingProgress.loaded}/{loadingProgress.total} markets...
</span>
<div class="mt-2 h-1.5 w-full overflow-hidden rounded-full bg-muted">
<div
class="h-full rounded-full bg-primary transition-all duration-300"
style="width: {loadingProgress.total > 0
? (loadingProgress.loaded / loadingProgress.total) * 100
: 0}%"
></div>
</div>
{/if}
</div>

Expand Down