Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Resolve conflicts by keeping both: - Round PnL display from this branch - Login page auth check and clock features from main Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add optional pnl field to MarketGroup proto - Add get_group_pnls() to calculate PnL per group for an account - Send group PnL when sending MarketGroups to clients - Update frontend to use backend-provided PnL instead of calculating from trade history - Remove trade history fetching for group PnL calculation - Hide redeem button when market is settled - Rename "Exchange for" to "Exchangeable for" Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace correlated subquery for last trade price with CTEs using GROUP BY to avoid per-row subquery execution. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Benchmark showed the CTE approach is actually slower: - With index: 24ms (old) vs 29ms (CTE) - Without index: 28ms (old) vs 48ms (CTE) The correlated subquery is more efficient because it only looks up last trades for markets with group_id > 0, while the CTE scans all trades upfront. This reverts commit ed4e7f0. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves ARB-97 ARB-96