Refactor for wgpu v23 compatibility with an example of wgpu device sharing#211
Merged
nathanielsimard merged 20 commits intotracel-ai:mainfrom Dec 5, 2024
Merged
Conversation
4 tasks
* Change type of `entry_point` from `&str` to `Option<&str>` * Change enum type of `WgpuDevice::Existing` from `wgpu::Id<wgpu::Device>` to `usize`
* Added auto-increment counter in init_existing_device * Added comments of usage
fcb6085 to
dd04e6c
Compare
* Also updated an argument, see https://docs.rs/wgpu-hal/latest/wgpu_hal/vulkan/struct.Adapter.html#method.device_from_raw
Contributor
|
In theory now that the OOB behaviour has been fixed this should work now, if you have time to re test on metal would be amazing :) Thank you! |
This comment has been minimized.
This comment has been minimized.
Member
I don't think the CI is building CUDA. |
Member
|
@AsherJingkongChen If you merge main, does it fix the CI? |
Closed
Contributor
Author
|
I don't get it why did it pass CI. I just updated feature flags. LOL. |
nathanielsimard
approved these changes
Dec 5, 2024
Member
This is because the CI errors was caused by the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
Checklist
cargo xtask test --ciscript has been executed.Changes
1. Modified
entry_pointTypeentry_pointfrom&strtoOption<&str>.2. Updated
WgpuDevice::ExistingEnum TypeWgpuDevice::Existingfromwgpu::Id<wgpu::Device>tou32.wgpu::Idno longer exists. Using au32ensures a unique identifier forWgpuDevice::Existing.Examples
device_sharingExample