Threadsafe Avro #144
Open
Threadsafe Avro #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avro encoding/decoding isn't threadsafe. This creates an encoder and decoder that uses `ThreadLocal` for storing the underlying Avro encoder/decoders. Assumes that most of the time people won't have multiple Avro exporters so defaults to constructing the encoder/decoder for them. The agent/collector should make sure there is only one instance of the encoder/decoder however.
Turns out this is threadsafe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avro encoding/decoding isn't threadsafe. This creates an encoder and decoder
that uses
ThreadLocalfor storing the underlying Avro encoder/decoders.Assumes that most of the time people won't have multiple Avro exporters so
defaults to constructing the encoder/decoder for them. The agent/collector
should make sure there is only one instance of the encoder/decoder however.