tag機能の追加 #169
Open
tag機能の追加 #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagatea
suggested changes
Oct 11, 2019
Contributor
nagatea
left a comment
nagatea
left a comment
There was a problem hiding this comment.
レビューしました
多少冗長になってもエラーチェックはしていくようにしよう
特にmodel.CreateItemは制約が少し厳しい(同じ名前は登録できない)のでテストが動かなくなる原因になるのでどこでテストが落ちるのかの切り分けにも使える
router/tags_test.go
Outdated
Comment on lines
44
to
47
| item, _ := model.CreateItem(model.Item{Name: "testPostTags2ItemItem"}) | ||
| tag1, _ := model.CreateTag("testPostTags2ItemTag1") | ||
| tag2, _ := model.CreateTag("testPostTags2ItemTag2") | ||
| tag3, _ := model.CreateTag("testPostTags2ItemTag3") |
Contributor
There was a problem hiding this comment.
エラーチェックした方がいいですね
上でassert := assert.New(t)して下のやつ消せばOK
router/tags_test.go
Outdated
Comment on lines
92
to
93
| item, _ := model.CreateItem(model.Item{Name: "testDeleteTagSuccessItem"}) | ||
| tag, _ := model.CreateTag("testDeleteTagSuccessTag") |
router/tags_test.go
Outdated
Comment on lines
78
to
79
| item, _ := model.CreateItem(model.Item{Name: "testDeleteTagFailItem"}) | ||
| tag, _ := model.CreateTag("testDeleteTagFailTag") |
nagatea
approved these changes
Oct 13, 2019
Contributor
nagatea
left a comment
nagatea
left a comment
There was a problem hiding this comment.
LGTM:+1:
クライアント側のUIについては今後考えていきましょ〜
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#135
タグの作成、付与、削除をついかしました
modelのテストが冗長な気がする