Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Comments

feat: Swap Network#394

Closed
maelswarm wants to merge 7 commits intotqtezos:developfrom
maelswarm:swap-net
Closed

feat: Swap Network#394
maelswarm wants to merge 7 commits intotqtezos:developfrom
maelswarm:swap-net

Conversation

@maelswarm
Copy link
Contributor

@maelswarm maelswarm commented Apr 28, 2021

swappp

Near completion except for issues with redux-persist and non-serializable datatypes in the store.

Config file for usage (deploy preview will not work)

{
  "mainnet": {
    "rpc": "https://rpc.tzbeta.net",
    "network": "mainnet",
    "bcd": {
      "api": "https://api.better-call.dev",
      "gui": "https://better-call.dev"
    },
    "tzkt": {
      "api": "https://staging.api.mainnet.tzkt.io"
    },
    "contracts": {
      "nftFaucet": "KT1QcxwB4QyPKfmSwjH1VRxa6kquUjeDWeEy",
      "marketplace": {
        "fixedPrice": {
          "tez": "KT1E8Qzgx3C5AAE4iGuXvqSQjdd21LK2aXAk"
        }
      }
    },
    "ipfsApi": "https://minter-api.tqhosted.com",
    "ipfsGateway": "https://tqtezos.mypinata.cloud"
  },
  "testnet": {
    "rpc": "https://rpctest.tzbeta.net",
    "network": "edonet",
    "bcd": {
      "api": "https://api.better-call.dev",
      "gui": "https://better-call.dev"
    },
    "tzkt": {
      "api": "https://staging.api.edo2net.tzkt.io"
    },
    "contracts": {
      "nftFaucet": "KT1Hagc5XQYzkX7HfRbUNXdi4CBfiENzbHiU",
      "marketplace": {
        "fixedPrice": {
          "tez": "KT1H4tMRW3o9GdPJ3r82ZC7BJiR6WgmYazUC"
        }
      }
    },
    "ipfsApi": "https://minter-api.tqhosted.com",
    "ipfsGateway": "https://tqtezos.mypinata.cloud"
  }
}

YAML + #395 may be a more compact/readable alternative as this grows.

UPDATE: working version without redux-persist implemented (although refreshing the page leads things out-of-sync as the store is not persisting).

To grab a build with redux-persist pull commit 4b74f98

https://stackoverflow.com/questions/35305661/where-to-write-to-localstorage-in-a-redux-app

localStorage instead of redux-persist?

@jacobarluck jacobarluck added this to the 0.7.1 milestone Apr 28, 2021
@ricklove
Copy link
Collaborator

What is the use case for this?

If I understand this correctly, this seems like something that would only have relevance to a developer and not an end user (i.e. it is a feature that would not provide any value to a user, but just add confusion).

However, I may be completely misunderstanding it or not seeing where it makes sense.

@maelswarm maelswarm changed the title Swap Network feat: Swap Network Apr 28, 2021
@obstropolos obstropolos removed this from the 0.7.1 milestone May 3, 2021
@maelswarm maelswarm closed this May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants