Conversation
Switch to 8.10.4
| initAuctionStorage as = AuctionStorage | ||
| { pausableAdmin = as | ||
| , currentId = 0 | ||
| , maxAuctionTime = 99999999999999999999 |
There was a problem hiding this comment.
are maxAuctionTime and maxConfigToStartTime ever tested?
There was a problem hiding this comment.
maxConfigToStartTime was already tested and I just added tests for maxAuctionTime. These tests are in the base tez auction contract tests, since the macro logic will not affect their behavior and these variables apply to all variants.
| deriving anyclass instance IsoValue ConfigureParam | ||
| deriving anyclass instance HasAnnotation ConfigureParam | ||
|
|
||
| consolationTokenId :: Natural |
There was a problem hiding this comment.
this doesn't appear to be tested with a non-zero ID
There was a problem hiding this comment.
Fixed in a new commit
| , testMinRaisePercent :: Natural | ||
|
|
||
| , testTokenBatches :: [[Common.FA2Token]] | ||
| , testMaxConsolationWinners :: Natural |
There was a problem hiding this comment.
how is this tested? e.g. I couldn't find a test to ensure that there are only this many winners or what happens when there are fewer participants than this max
There was a problem hiding this comment.
It is tested in the sense that genConsolationWinners generates a list of bid indices that ought to receive a consolation token, and that function takes into account maxConsolationWinners and the number of bidders which ranges from less than to greater than maxConsolationsWinners. The individual tests check that the consolation tokens were correctly distributed using the list returned by genConsolationWinners.
2 participants
This PR adds both the consolation auction as well as positional auction variants of the english auction contract