Adding strikethrough support via the htmlStrike highlight group
#186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think the changes I made in #185 should be applied to this patch, since strikethrough is a variant of emphasis. See https://github.github.com/gfm/#strikethrough-extension-. |
As pointed out by @tomtomjhj it would be good to follow the lead of the other emphasis syntax groups: allow no whitespace after/before the emphasis delimiter and also don't let emphasis span multiple lines.
Contributor
Author
|
Good catch, thanks @tomtomjhj! I've modified the syntax rule accordingly. |
Owner
|
Let's go with |
tpope
reviewed
Jan 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As was requested in #26 and implemented in #34 (but with an unsatisfactory highlight group) I've taken the liberty to alter that PR to use a better highlight group instead.
(I've also had to adjust @therod's changes to fit into the current state of the syntax file.)