Fix clang warnings about forward definitions#2
Open
lehenbauer wants to merge 4 commits intotpoindex:masterfrom
Open
Fix clang warnings about forward definitions#2lehenbauer wants to merge 4 commits intotpoindex:masterfrom
lehenbauer wants to merge 4 commits intotpoindex:masterfrom
Conversation
TSP_Util_string_compare_const was called before it was used without being forward-declared. This puts the definition before its first use.
Author
|
Also getting forward declaration warnings for Tcl_PushCallFrame and Tcl_PopCallFrame. Their names seem to indicate they should be defined in tcl.h, but they are defined in tclIntDecls.h. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TSP_Util_string_compare_const was forward-declared in TSP_util.c. A trivial reordering declares the function before its first call.
clang on FreeBSD was warning about forward definitions for srand48 and drand48 and this fixes that by importing stdlib.h, which should be pretty safe these days.