ensure legacy methods & cache vk #98
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
reviewed
Nov 17, 2025
| if derived_vk_bytes != self._provided_vk_bytes: | ||
| raise ValueError("Provided Ed25519 public key does not match derived key from seed") | ||
| return Ed25519PublicKey.from_public_bytes(self._provided_vk_bytes) | ||
| return self.sk.public_key() |
Collaborator
There was a problem hiding this comment.
I don't think you need to call it, it should work like a property e.g. self.public_key
Member
Author
There was a problem hiding this comment.
self.sk is a Ed25519PrivateKey, confusing that we also have a self.public_key just below
Collaborator
There was a problem hiding this comment.
I made the property because it seemed better, it was the same as pubkey() before but just the property version
This reverts commit 727e683.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses comments from #97
pubkeymethod still worksvk