Sub accounts #111
Merged
Sub accounts #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farnyser
requested changes
Jan 17, 2026
tplus/model/order.py
Outdated
| """Whether to spend from spot balance (True) or margin balance (False).""" | ||
|
|
||
| @classmethod | ||
| def main_spot(cls) -> TradeTarget: |
Collaborator
There was a problem hiding this comment.
maybe rename to
main_account_spot_trademargin_account_spot_trade
And addmargin_account_margin_trade
_trade or _balance
Because margin_spot is very confusing
farnyser
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.