Skip to content

Feature/refactor client layer#74

Open
jeanparpaillon wants to merge 10 commits intodevelopfrom
feature/refactor-client-layer
Open

Feature/refactor client layer#74
jeanparpaillon wants to merge 10 commits intodevelopfrom
feature/refactor-client-layer

Conversation

@jeanparpaillon
Copy link
Collaborator

No description provided.

@jeanparpaillon jeanparpaillon force-pushed the feature/refactor-client-layer branch from 13e78df to e309974 Compare December 18, 2020 16:27
@johngiffin
Copy link
Collaborator

Looks like this branch causes DS tests to break, beyond just the new usage/options. Wasn't able to see immediately what the issue is. DS tests pass using the develop branch.

@johngiffin
Copy link
Collaborator

@jeanparpaillon There's still this example in the README which is outdated:

CoAP.Client.request(
  :con,
  method,
  url,
  request_payload,
  %{retries: retries, timeout: @wait_timeout, ack_timeout: timeout, tag: tag}
)

@jeanparpaillon jeanparpaillon force-pushed the feature/refactor-client-layer branch from 0ee2689 to e29f473 Compare December 29, 2020 09:26
@jeanparpaillon
Copy link
Collaborator Author

Client part should be ready for full review.
Server part has not been updated. We may consider splitting into:

  • coap - base, include UDP socket
  • coapc - client
  • coap_phoenix, coap_server ?
  • In future, coap_adapter_* - like websocket, uart, tcp ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants