Update MutableMapping import for Python 3.10#44
Open
jbosboom wants to merge 1 commit intotpircher-zz:masterfrom
Open
Update MutableMapping import for Python 3.10#44jbosboom wants to merge 1 commit intotpircher-zz:masterfrom
jbosboom wants to merge 1 commit intotpircher-zz:masterfrom
Conversation
The ABCs were moved to collections.abc in Python 3.3, but aliases were provided in the collections module to avoid breaking code. Python 3.10 removed those aliases.
|
Unfortunately I have been locked out from the GitHub account; the fix is now applied to the new repository in https://github.com/tpircher/pycrc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ABCs were moved to collections.abc in Python 3.3, but aliases were in the collections module to avoid breaking code. Python 3.10 removed those aliases.
The Travis config in the repo declares compatibility with Python 3.2, which does not have collections.abc. I don't know if this package still runs on 3.2, and virtualenv doesn't support 3.2 (according to its docs, I didn't try), so I couldn't test it on 3.2. On the assumption that no one cares about 3.2 anymore, this commit does not catch ImportError and fall back to the old import.