Skip to content

feat(rules): add NAT gateway and SageMaker discovery checks#53

Merged
dannysteenman merged 3 commits intomainfrom
codex/aws-discovery-nat-sagemaker-checks
Mar 31, 2026
Merged

feat(rules): add NAT gateway and SageMaker discovery checks#53
dannysteenman merged 3 commits intomainfrom
codex/aws-discovery-nat-sagemaker-checks

Conversation

@axonstone
Copy link
Copy Markdown
Contributor

@axonstone axonstone commented Mar 30, 2026

Summary

  • What changed?
    • Added AWS discovery dataset support and built-in rules for idle NAT Gateways and running SageMaker notebook instances.
    • Registered the new datasets and rules, added hydrators and evaluators, updated docs, and added changesets for @cloudburn/sdk and @cloudburn/rules.
  • Why was this needed?
    • The ruleset already covered adjacent AWS waste checks, but it was still missing discovery coverage for two findings supported by the reference WasteFinder logic: idle NAT Gateways and running SageMaker notebooks.

Diagram

flowchart LR
  RE["AWS Resource Explorer catalog"] --> NAT["ec2:natgateway"]
  RE --> SM["sagemaker:notebook-instance"]
  NAT --> H1["SDK NAT hydrator\nDescribeNatGateways + CloudWatch metrics"]
  SM --> H2["SDK SageMaker hydrator\nDescribeNotebookInstance"]
  H1 --> D1["aws-ec2-nat-gateway-activity"]
  H2 --> D2["aws-sagemaker-notebook-instances"]
  D1 --> R1["CLDBRN-AWS-EC2-10"]
  D2 --> R2["CLDBRN-AWS-SAGEMAKER-1"]
Loading

Scope

  • cloudburn (cli)
  • @cloudburn/sdk
  • @cloudburn/rules
  • docs/community files

Release Notes

  • Added a .changeset/*.md file for published package changes
  • No published package changes in this PR

Verification

  • pnpm lint
  • pnpm typecheck
  • pnpm test
  • pnpm build
  • pnpm verify

Boundary Checks

  • No engine/parser/provider logic added to @cloudburn/rules
  • CLI delegates scan logic to SDK
  • README/CONTRIBUTING/docs updated when behavior changed

Open with Devin

@axonstone axonstone added the enhancement New feature or request label Mar 30, 2026
@axonstone axonstone requested a review from dannysteenman March 30, 2026 13:01
…at-sagemaker-checks

* origin/main:
  feat(rules): add AWS IaC cost review rules (#52)

# Conflicts:
#	docs/reference/rule-ids.md
#	packages/rules/src/aws/ec2/index.ts
#	packages/rules/test/exports.test.ts
#	packages/rules/test/rule-metadata.test.ts
#	packages/sdk/test/exports.test.ts
@dannysteenman dannysteenman marked this pull request as ready for review March 30, 2026 17:32
devin-ai-integration[bot]

This comment was marked as resolved.

@dannysteenman dannysteenman merged commit b59a9f3 into main Mar 31, 2026
6 checks passed
@dannysteenman dannysteenman deleted the codex/aws-discovery-nat-sagemaker-checks branch March 31, 2026 07:27
@github-actions github-actions bot mentioned this pull request Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants