Skip to content

feat(rules): add AWS IaC cost review rules#52

Merged
dannysteenman merged 2 commits intomainfrom
codex/aws-iac-cost-rules
Mar 30, 2026
Merged

feat(rules): add AWS IaC cost review rules#52
dannysteenman merged 2 commits intomainfrom
codex/aws-iac-cost-rules

Conversation

@dannysteenman
Copy link
Copy Markdown
Member

Summary

  • What changed?
    Added new AWS IaC cost review rules for S3, ECR, EBS, EC2, DynamoDB, Lambda, and RDS, and extended the existing ECS and Redshift rules to support IaC scans. The SDK static registry now normalizes the additional Terraform and CloudFormation shapes those rules need.
  • Why was this needed?
    This expands pre-deploy cost coverage for AWS infrastructure that is easy to detect statically in Terraform and CloudFormation before expensive defaults or wasteful configurations reach runtime.

Diagram

flowchart LR
  IaC["Terraform / CloudFormation"] --> Registry["AWS static registry"]
  Registry --> Datasets["Normalized AWS static datasets"]
  Datasets --> Rules["AWS cost review rules"]
  Rules --> Findings["IaC findings"]
Loading

Scope

  • cloudburn (cli)
  • @cloudburn/sdk
  • @cloudburn/rules
  • docs/community files

Release Notes

  • Added a .changeset/*.md file for published package changes
  • No published package changes in this PR

Verification

  • pnpm lint
  • pnpm typecheck
  • pnpm test
  • pnpm build
  • pnpm verify

Boundary Checks

  • No engine/parser/provider logic added to @cloudburn/rules
  • CLI delegates scan logic to SDK
  • README/CONTRIBUTING/docs updated when behavior changed

Related Issues

None found via gh issue list.

@dannysteenman dannysteenman added the enhancement New feature or request label Mar 27, 2026
@dannysteenman dannysteenman requested a review from axonstone March 27, 2026 18:25
@axonstone
Copy link
Copy Markdown
Contributor

roborev: Combined Review (aff9c3f)

Verdict: No High or Critical findings identified.

No deduplicated findings met the High/Critical threshold for inclusion.

Medium/Low issues were reported by some reviewers, but are omitted here per instruction.


Synthesized from 4 reviews (agents: claude-code, codex | types: default, security)

@dannysteenman dannysteenman marked this pull request as ready for review March 27, 2026 19:27
devin-ai-integration[bot]

This comment was marked as resolved.

- make CloudFormation ECS autoscaling correlation independent of resource order
- add regression coverage for reversed ScalingPolicy and ScalableTarget ordering
- add metadata coverage for the new AWS cost rules
@axonstone
Copy link
Copy Markdown
Contributor

Re: comment 4144486377

Already addressed. The combined review reported no actionable high or critical findings, so no code change was required for that summary comment.

@axonstone
Copy link
Copy Markdown
Contributor

Re: comment 4144486377

No actionable findings were included in this synthesized review note, so there was nothing to change on the branch. I re-verified the PR state locally with pnpm verify while closing out the remaining review threads.

@axonstone
Copy link
Copy Markdown
Contributor

Re: comment 4144486377

Reviewed. This synthesized summary did not include any actionable findings, so no code changes were needed.

@dannysteenman dannysteenman merged commit 8cd3b28 into main Mar 30, 2026
6 checks passed
@dannysteenman dannysteenman deleted the codex/aws-iac-cost-rules branch March 30, 2026 17:16
@github-actions github-actions bot mentioned this pull request Mar 30, 2026
axonstone added a commit that referenced this pull request Mar 30, 2026
…at-sagemaker-checks

* origin/main:
  feat(rules): add AWS IaC cost review rules (#52)

# Conflicts:
#	docs/reference/rule-ids.md
#	packages/rules/src/aws/ec2/index.ts
#	packages/rules/test/exports.test.ts
#	packages/rules/test/rule-metadata.test.ts
#	packages/sdk/test/exports.test.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants