new: Souei-Overlay #61
Conversation
Users must now specify complete filename with extension (e.g., GothicRD.ttf) in settings. This prevents the overlay from attempting to load non-existent font formats.
|
GabuTheDev
left a comment
GabuTheDev
left a comment
There was a problem hiding this comment.
Looks alright overall.
Please read the individual comments and adjust your code as needed.
Some suggestions, but not needed for approval:
- I would suggest that for the
In-Game.png, you also provide a background. - The js deps can be minified.
counters/Souei-Overlay by -Souei/deps/reconnecting-websocket.min.js
Outdated
Show resolved
Hide resolved
|
Thanks for the review! I'd like to leave it without a background for now if that's alright. Actually, would it be possible to use the screenshots I sent initially? Also switched to the official tosu WebSocketManager like you mentioned. Cheers! |
|
Alright, everything should be correct now, right? |
| if (!window.COUNTER_PATH) { | ||
| window.COUNTER_PATH = window.location.pathname; | ||
| } |
There was a problem hiding this comment.
i dont think this one is needed, because tosu add this one when you using overlay via http://127.0.0.1:24050/OVERLAY_NAME
| const fontPath = `fonts/${fontFileName}`; | ||
|
|
||
| try { | ||
| const fontFace = new FontFace('CustomFont', `url(${fontPath})`); |
There was a problem hiding this comment.
fontPath used only once, so you can do this
| const fontPath = `fonts/${fontFileName}`; | |
| try { | |
| const fontFace = new FontFace('CustomFont', `url(${fontPath})`); | |
| try { | |
| const fontFace = new FontFace('CustomFont', `url(fonts/${fontFileName})`); |
|
@int80x0 check requested changes |
- Remove unused fontPath variable in loadCustomFont() - Remove redundant window.COUNTER_PATH initialization (handled by tosu)
|
@cyperdark
Should be good to go now! |
|
@int80x0 you didn't commit the changes. |
oooops |
3 participants
This overlay is based on an old gosumemory overlay I downloaded years ago. The original base is not my work, but I unfortunately can no longer find it online and don't remember the original creator's name - otherwise I would have gladly credited and linked them in this project.
Since I've been using this overlay on my Twitch stream for a very long time, I decided to modernize it and migrate it to the tosu v2 API to keep it functional and up-to-date.