SystemDesc support for Pose and Stepper systems#5
Open
robert-w-gries wants to merge 1 commit intotopokel:0.4.0from
robert-w-gries:fixed_systemdesc
Open
SystemDesc support for Pose and Stepper systems#5robert-w-gries wants to merge 1 commit intotopokel:0.4.0from robert-w-gries:fixed_systemdesc
robert-w-gries wants to merge 1 commit intotopokel:0.4.0from
robert-w-gries:fixed_systemdesc
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resubmitting PR with cleaner branch. The following builds compile successfully:
cargo build --features "dim2"cargo build --features "dim3"cargo build --features "dim2 amethyst"< Need to use patch from Fix compile error with dim2 feature #4 firstcargo build --features "dim3 amethyst"I didn't include a
SystemDescfor theBatchsystem because it doesn't seem to fit the use case ofSystemDesc.I couldn't test the amethyst example due to compile errors.
I couldn't test my personal project with these changes due to issues with how resources are initialized. Haven't dug too deep into it, but I believe the
Worldresources are not initialized for some reason.