Skip to content

Fix build with latest wlroots, dbus libs#5

Open
depau wants to merge 12 commits intotopisani:masterfrom
depau-forks:fixup
Open

Fix build with latest wlroots, dbus libs#5
depau wants to merge 12 commits intotopisani:masterfrom
depau-forks:fixup

Conversation

@depau
Copy link

@depau depau commented Feb 11, 2020

I tried to make commits self-explanatory.

Notice that this is my first time dealing with C++ code, so please do review :)

@topisani
Copy link
Owner

Thanks, this looks good!

I'd prefer it if it could build with the chromium dbusc++ fork, since that's a lot less buggy than the mainline, but then maybe we should add that as a submodule.

It's been some time since I've worked on this, but I still use cloth-notifications, cloth-outputs and cloth-lock on a daily basis, so I appreciate the help.

Tell me when you are done with your patches, and I'll merge it

@depau
Copy link
Author

depau commented Feb 14, 2020

I noticed mainline dbus-c++ generated code doesn't build with Clang for reasons that are beyond my knoweledge, does chromium's?

Anyway it should be pretty much good with these patches, next week I'll do some more work and eventually switch to it, if you want to merge it it's fine, I'll open a new PR if needed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants