Fix build with latest wlroots, dbus libs#5
Open
depau wants to merge 12 commits intotopisani:masterfrom
Open
Conversation
This moves the protocol inside the project and removes the wlroots submodule.
I silenced those caused by generated code.
Warning only shows with -O2
...so I can create a package easily
Owner
|
Thanks, this looks good! I'd prefer it if it could build with the chromium dbusc++ fork, since that's a lot less buggy than the mainline, but then maybe we should add that as a submodule. It's been some time since I've worked on this, but I still use cloth-notifications, cloth-outputs and cloth-lock on a daily basis, so I appreciate the help. Tell me when you are done with your patches, and I'll merge it |
Author
|
I noticed mainline dbus-c++ generated code doesn't build with Clang for reasons that are beyond my knoweledge, does chromium's? Anyway it should be pretty much good with these patches, next week I'll do some more work and eventually switch to it, if you want to merge it it's fine, I'll open a new PR if needed :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to make commits self-explanatory.
Notice that this is my first time dealing with C++ code, so please do review :)