#53: Add use_task_data and use_edge_data parameters for simulation. #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to simplify observation plan generation and instead pass the onus of experiment combinations onto the simulator. These changes also include some polishing refactoring of the Task and Scheduler classes and their respective tests. Future work to refactor and simplify/move redundancies has been identified and added as #TODOs; I'll add this to a GitHub issue once this has been self-reviewed.
This is so we can figure out what our experimental parameters were.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to simplify observation plan generation and instead pass the onus of experiment combinations onto the simulator.
These changes also include some polishing refactoring of the Task and Scheduler classes and their respective tests. Future work to refactor and simplify/move redundancies has been identified and added as #TODOs; I'll add this to a GitHub issue once this has been self-reviewed.