-
Notifications
You must be signed in to change notification settings - Fork 0
Language library refactor #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…ername/terminalNameExtra
ee16341 to
0a15895
Compare
ToopherDotNet/ToopherDotNet.cs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sessionToken should be requestToken here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a default value for TTL so users don't have to specify it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, can you add an overload that takes parameters as a Dictionary<string, string>?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes have been made.
…airing and UserTerminal constructors
ef624f5 to
dfc0fde
Compare
b0a97bb to
97567bd
Compare
97567bd to
2278ac4
Compare
Updated existing toopher-dotnet library using blueprint v3