Skip to content

Conversation

@AndreaDuina
Copy link

Currently in the right window of plottr-monitr python files appear first.
This is very inconvenient because they are very rarely checked and occupy a lot of space.

Images should appear first instead, such that users don't have to scroll down every time they want to check a measurement.

I added a very simple custom sort logic, which enforces the following order:

  1. Images
  2. Folder path
  3. Param dict
  4. Anything else
  5. Python files

@marcosfrenkel
Copy link
Collaborator

@AndreaDuina Thank you for the contribution, I haven't been able to test it locally just yet, but it seems that the check is an easy fix, simply specify what the return value is for the sort function and that should be it.

@AndreaDuina
Copy link
Author

AndreaDuina commented Feb 14, 2025

Should be fine now, let me know!

There are errors for higher python versions due to a missing type definition in utils/num.py, which I haven't touched, so I'm assuming you're already aware of that

@marcosfrenkel
Copy link
Collaborator

Hello @AndreaDuina sorry for the extremely late response on this.

The mypy errors that were failing this PR were fixed, what remains are real errors that need to be addressed before being able to merge this PR.
I have added a new commit to the master branch that passes the monitr.py file through a linter so that all those changes are not part of this PR (this makes it hard to review). If you could update the branch to bring those changes it would be great.

Sorry for the delay and inconvenience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants