Skip to content

app: Improve 500 handler #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
supertassu merged 2 commits into from
Dec 4, 2025
Merged

app: Improve 500 handler #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d52cd6
app: Improve 500 handler
supertassu Dec 4, 2025
e248edf
auto update of tag
Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions helm-quarry/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
web:
repository: 'quay.io/wikimedia-quarry/quarry'
tag: pr-94 # web tag managed by github actions
tag: pr-95 # web tag managed by github actions
resources:
requests:
memory: "300Mi"
Expand All @@ -11,7 +11,7 @@ web:

worker:
repository: 'quay.io/wikimedia-quarry/quarry'
tag: pr-94 # worker tag managed by github actions
tag: pr-95 # worker tag managed by github actions
resources:
requests:
memory: "400Mi"
Expand Down
6 changes: 5 additions & 1 deletion quarry/web/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from flask import current_app, Flask, render_template, g, Response
from flask_caching import Cache
from werkzeug.exceptions import HTTPException
from werkzeug.middleware.proxy_fix import ProxyFix

from .config import get_config
Expand Down Expand Up @@ -31,7 +32,10 @@ def kill_context(exception=None):


def handle_internal_error(e: Exception):
return render_template("500.html")
if isinstance(e, HTTPException):
return e
current_app.logger.error("Failed to handle request", exc_info=e)
return render_template("500.html"), 500


def create_app(test_config=None):
Expand Down