Improve maintenance message CSS #23
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhinus
previously approved these changes
Sep 2, 2024
Bug: T343644 Change-Id: I36fde4e4208682ecf30bc4dbe1152f220942e08a
supertassu
force-pushed
the
maintenance-css/T343644
branch
from
2e73a2a to
357a8f5
Compare
Member
|
The proposed colors here had relatively low contrast values unfortunately. In the latest commit I adjusted the background color as well, so now the main text color passes WCAG AAA requirements and the link text passes WCAG AA. |
Member
|
Sigh, something has again broken the pipelines for forks. I'm not in the mood for debugging that atm, so I'll re-create on branch in this repo and merge from there. (Sorry for that!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: T343644