Skip to content

Refactor buttons to semantic HTML for accessibility #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tonymendonca23 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor buttons to semantic HTML for accessibility #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2026-01-27 - Semantic Buttons vs Divs
**Learning:** Found critical "buttons" implemented as `div`s with `h4` tags, rendering them inaccessible to keyboard users and screen readers.
**Action:** Always prioritize converting `div` buttons to semantic `<button>` elements over adding ARIA attributes, but remember to explicitly reset CSS properties (font, border, background) as buttons don't inherit them by default.
230 changes: 115 additions & 115 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,115 +1,115 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="style.css" />
<link rel="preconnect" href="https://fonts.googleapis.com" />
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin />
<link
href="https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,100..900;1,100..900&display=swap"
rel="stylesheet"
/>
<title>Cooking Recipe website</title>
</head>
<body>
<header>
<div class="logo">
<h1>Cooking<span>Recipes</span></h1>
</div>
<nav class="navbar">
<ul>
<li><a href="#">Home</a></li>
<li><a href="#">About</a></li>
<li><a href="#">Recipes</a></li>
</ul>
</nav>
</header>
<div class="home">
<div class="home-content">
<h3>Cooking Recipes</h3>
<p class="home-parag">
Welcome to our cooking recipes website! Here, you'll find a vast
collection of delicious and easy-to-follow recipes that are from
Guyana.
</p>
<div class="btn">
<h4>Join Us</h4>
</div>
</div>
<div class="home-img">
<img src="./assets/home_img.png" alt="home-img" />
</div>
</div>
<div class="about">
<div class="about-content">
<p class="food-parag">
Welcome to our cooking recipes website! Here, you'll find a vast
collection of delicious and easy-to-follow recipes that are from
Guyana.
<br />
<br />
Below you'll see some of our dishes that we have prepared for you.
</p>
</div>
<div class="recipes">
<div class="recipe">
<img src="./assets/Cassava-eggball.webp" alt="Cassava-eggball" />
<div class="recipe-content">
<p>Cassava-eggball.</p>
</div>
</div>
<div class="recipe">
<img src="./assets/Fried-Rice.jpg" alt="Fried-Rice" />
<div class="recipe-content">
<p>Fried-rice.</p>
</div>
</div>
<div class="recipe">
<img src="./assets/Guyanese-Cook-up-500x500.webp" alt="recipe3" />
<div class="recipe-content">
<p>Guyanese Cook-up.</p>
</div>
</div>
<div class="recipe">
<img src="./assets/roti_curry.jpg" alt="recipe4" />
<div class="recipe-content">
<p>Roti And Curry chicken.</p>
</div>
</div>
</div>
</div>
<div class="quote-section">
<p>
"One cannot think well, love well, sleep well, if one has not dined
well. One cannot think well, love well, sleep well, if one has not dined
well."
</p>
</div>
<div class="call-to-action">
<div class="call-content">
<div class="cta">
<h3>Call to action! It's time!</h3>
<p>Sign up to our website and get the best food recipes delivered to your inbox.</p>
</div>
<div class="sign-up-btn">
<h4>Sign up</h4>
</div>
</div>
</div>
<footer>
<p>Copyright &copy; 2023 Cooking Recipes</p>
</footer>
</body>
</html>
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="style.css" />
<link rel="preconnect" href="https://fonts.googleapis.com" />
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin />
<link
href="https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,100..900;1,100..900&display=swap"
rel="stylesheet"
/>
<title>Cooking Recipe website</title>
</head>
<body>
<header>
<div class="logo">
<h1>Cooking<span>Recipes</span></h1>
</div>
<nav class="navbar">
<ul>
<li><a href="#">Home</a></li>
<li><a href="#">About</a></li>
<li><a href="#">Recipes</a></li>
</ul>
</nav>
</header>

<div class="home">
<div class="home-content">
<h3>Cooking Recipes</h3>
<p class="home-parag">
Welcome to our cooking recipes website! Here, you'll find a vast
collection of delicious and easy-to-follow recipes that are from
Guyana.
</p>
<button class="btn">
Join Us
</button>
</div>
<div class="home-img">
<img src="./assets/home_img.png" alt="home-img" />
</div>
</div>

<div class="about">
<div class="about-content">
<p class="food-parag">
Welcome to our cooking recipes website! Here, you'll find a vast
collection of delicious and easy-to-follow recipes that are from
Guyana.
<br />
<br />
Below you'll see some of our dishes that we have prepared for you.
</p>
</div>

<div class="recipes">
<div class="recipe">
<img src="./assets/Cassava-eggball.webp" alt="Cassava-eggball" />
<div class="recipe-content">
<p>Cassava-eggball.</p>
</div>
</div>

<div class="recipe">
<img src="./assets/Fried-Rice.jpg" alt="Fried-Rice" />
<div class="recipe-content">
<p>Fried-rice.</p>
</div>
</div>

<div class="recipe">
<img src="./assets/Guyanese-Cook-up-500x500.webp" alt="recipe3" />
<div class="recipe-content">
<p>Guyanese Cook-up.</p>
</div>
</div>

<div class="recipe">
<img src="./assets/roti_curry.jpg" alt="recipe4" />
<div class="recipe-content">
<p>Roti And Curry chicken.</p>
</div>
</div>
</div>
</div>

<div class="quote-section">
<p>
"One cannot think well, love well, sleep well, if one has not dined
well. One cannot think well, love well, sleep well, if one has not dined
well."
</p>
</div>

<div class="call-to-action">
<div class="call-content">
<div class="cta">
<h3>Call to action! It's time!</h3>
<p>Sign up to our website and get the best food recipes delivered to your inbox.</p>
</div>

<button class="sign-up-btn">
Sign up
</button>
</div>
</div>

<footer>
<p>Copyright &copy; 2023 Cooking Recipes</p>
</footer>

</body>
</html>
Loading